Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinfoil #35

Merged
merged 2 commits into from
Oct 2, 2018
Merged

tinfoil #35

merged 2 commits into from
Oct 2, 2018

Conversation

dmonego
Copy link
Contributor

@dmonego dmonego commented Oct 2, 2018

Contributor Checklist

Hi Friend! Thanks for contributing an open source art. Please make sure
you check off all the items below!

  • You've added your image as docs/assets/<year>/<image>.jpg
  • The image is not greater than 1024px in size (smaller runs faster!)
  • Your metadata post is added with the same <image> identifier in docs/_works/<year>/<image>.md
  • You have all fields in your metadata file described in the README

Thanks for contributing, the robots can't wait to start working!

How does this work?

When you create the pull request, it will start a workflow (that will appear below)
on a testing server called "CircleCI" that is going to use a docker container
to generate an artistic piece (well, many!) for the gallery. There are a few steps here:

  • build will generate the art pieces, and save them as artifacts for us the preview! You can look at the link for the build step in the workflow and click on "Artifacts" to see them.
  • update_cache just saves things for next time.
  • hold is a step that requires a manual approval, meaning an administrator of the gallery checks the artifacts, and then gives the good to go!
  • deploy sends the images off to the gallery, where they can be appreciated by all.

Feel free to ask questions in the comments below, and let us know if anything is unclear. Thank
you again for your contribution!

@dmonego
Copy link
Contributor Author

dmonego commented Oct 2, 2018

Referencing #29

@vsoch
Copy link
Owner

vsoch commented Oct 2, 2018

heyo @dmonego ! I just updated the circle config so that the deploy will work as expected, so we may need you to rebase! Thanks in advance for your patience - I didn't get a chance to test fully given that it's a simple change (and needs a contribution to do so) so it looks like you are the first tester :)

@vsoch
Copy link
Owner

vsoch commented Oct 2, 2018

The artifacts look good (super cool effect!) I'm going to merge and fingers crossed the new CI setup will build and deploy without any issues. Thanks for your contribution! If there are outstanding issues with the new setup I'll take care of fixing them up.

@vsoch vsoch self-requested a review October 2, 2018 04:21
Copy link
Owner

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick request - please name the image and markdown according to the instructions in the README, so the name should be:

2018/tim-holman-tinfoil.jpg

I'm also fairly certain you are not Tim Holman, so you might want to look at all the metadata there and make sure it is correct :)

@dmonego
Copy link
Contributor Author

dmonego commented Oct 2, 2018

Oops! That should be fixed, and the changes to the file names are in there.

@vsoch
Copy link
Owner

vsoch commented Oct 2, 2018

Thank you! Merging.

@vsoch vsoch merged commit ba0d22b into vsoch:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants