Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add sponsored badge option #1098

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Feature: add sponsored badge option #1098

merged 3 commits into from
Nov 28, 2023

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Nov 16, 2023 •
edited
Loading

What problem is this solving?

📢 We do not intend to ship this until after black friday! 📢

⚠️ The failed CI tests are not related to this change ⚠️

Our current solution for sponsored products exports a sponsored-badge block in the Sponsored Products app. However, this requires changes in the store-theme in order to render sponsored products.

By having this option here, the Product Summary app can render this badge dynamically and automatically, without having to change the store-theme.

How to test it?

Workspace

Screenshots or example usage:

Screenshot 2023-11-16 at 13 31 39

Describe alternatives you've considered, if any.

Related to / Depends on

Related to vtex-apps/product-summary#385.

@hcaula hcaula self-assigned this Nov 16, 2023
@hcaula hcaula requested review from a team as code owners November 16, 2023 16:36
@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 16, 2023 •
edited by hcaula
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@hcaula hcaula mentioned this pull request Nov 16, 2023
Merged
1 task
thalytafabrine
thalytafabrine approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@thalytafabrine thalytafabrine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

filipewl
filipewl approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

As mentioned in the PR's description, the failing tests were introduced in the previous merged PR (the previous to that one was passing). This PR introduces no new test error, so that's enough for me until we fix them at the main branch.

@filipewl filipewl merged commit 6b699a3 into master Nov 28, 2023
2 of 3 checks passed
@filipewl filipewl deleted the feature/sponsored-badge branch November 28, 2023 17:24
@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 28, 2023

Your PR has been merged! App is being published. 🚀
Version 3.169.5 → 3.170.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

filipewl pushed a commit to vtex-apps/product-summary that referenced this pull request Nov 28, 2023
Feature: add sponsored tag if applicable (#385)
bb563ce 
#### What problem is this solving?

These changes renders a sponsored tag above the product's name if the
product is sponsored.

#### How to test it?

<!--- Don't forget to add a link to a Workspace where this branch is
linked -->


[Workspace](https://caula--sjdigital.myvtex.com/cotonete?_q=cotonete&map=ft)

#### Screenshots or example usage:

<!--- Add some images or gifs to showcase changes in behaviour or
layout. Example: before and after images -->
![Screenshot 2023-11-16 at 13 31
39](https://github.com/vtex-apps/store-components/assets/15937541/ac7a72d3-7da5-413f-9156-1b231990f360)

#### Related to / Depends on

<!--- Optional -->
Depends on:
- [ ] vtex-apps/store-components#1098.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalytafabrine thalytafabrine thalytafabrine approved these changes

@filipewl filipewl filipewl approved these changes

@JulianaMeyerArruda JulianaMeyerArruda Awaiting requested review from JulianaMeyerArruda JulianaMeyerArruda is a code owner automatically assigned from vtex-apps/technical-writers

@eduardoformiga eduardoformiga Awaiting requested review from eduardoformiga eduardoformiga is a code owner automatically assigned from vtex-apps/store-framework-devs

@lucasfp13 lucasfp13 Awaiting requested review from lucasfp13 lucasfp13 is a code owner automatically assigned from vtex-apps/store-framework-devs

@lariciamota lariciamota Awaiting requested review from lariciamota lariciamota is a code owner automatically assigned from vtex-apps/store-framework-devs

@hiagolcm hiagolcm Awaiting requested review from hiagolcm

Assignees

@hcaula hcaula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hcaula @filipewl @thalytafabrine