Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Prop hideUnavailableVariations that enables hiding unavailable variations from DOM #1110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mihaidanieldumitru
Copy link

What problem is this solving?

Some clients have products with many variations that are unavailable at a time and they want to hide these variations and not with CSS because the showMore button still remains with the total number of variations.

How to test it?

Workspace Link 1
Workspace Link 2

Screenshots or example usage:

  "sku-selector": {
    "props": {
      "visibility": "more-than-one",
      "sortVariationsByLabel": true,
      "hideUnavailableVariations": true
    }
  },

Before

image
image

After

image
image
image

Copy link
Contributor

vtex-io-ci-cd bot commented Jul 11, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@mihaidanieldumitru mihaidanieldumitru force-pushed the feature/hide-unavailable-variations branch 2 times, most recently from 5e3e197 to badbaa5 Compare July 11, 2024 09:05
@mihaidanieldumitru mihaidanieldumitru force-pushed the feature/hide-unavailable-variations branch from badbaa5 to c0e4339 Compare July 18, 2024 09:54
@mihaidanieldumitru mihaidanieldumitru force-pushed the feature/hide-unavailable-variations branch from c0e4339 to 14d54b9 Compare August 2, 2024 13:21
@mihaidanieldumitru mihaidanieldumitru force-pushed the feature/hide-unavailable-variations branch from 14d54b9 to dc86f64 Compare September 3, 2024 07:41
@mihaidanieldumitru mihaidanieldumitru force-pushed the feature/hide-unavailable-variations branch from dc86f64 to 27dfeb5 Compare September 12, 2024 06:06
@mihaidanieldumitru mihaidanieldumitru force-pushed the feature/hide-unavailable-variations branch from 27dfeb5 to 9d9af8c Compare November 11, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant