Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pdp fetch priority #1122

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gabridevs
Copy link

What problem is this solving?

This change improves page performance by ensuring the main product image is prioritized during loading. By setting the fetchpriority: 'high' for the first product image, we ensure that the most important image (usually the first one) is loaded first, enhancing user experience, especially for pages with multiple images.

How to test it?

You can test this change by visiting the following workspace where the branch is linked. Check the loading behavior of the first product image, ensuring it is loaded before others when opening a product page.

[Workspace](Link goes here!)

Screenshots or example usage:

Screenshot 2024-10-16 alle 19 57 52

Describe alternatives you've considered, if any.

No alternatives considered as fetchpriority: 'high' is a straightforward and effective solution for this problem.

@gabridevs gabridevs requested a review from a team as a code owner October 17, 2024 09:19
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 17, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@gabridevs
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

* [ ]  Patch (backwards-compatible bug fixes)

* [x]  Minor (backwards-compatible functionality)

* [ ]  Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

* [ ]  No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant