Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SKU Selector displayPrices prop #897

Closed

Conversation

juliomoreira
Copy link
Contributor

What problem is this solving?

  • Adds the option to show the SKU variation price in SKU Selector. This is best suited when displayMode is set to select but it works as well in default mode as shown bellow;

How to test it?

  1. Open Workspace;
  2. Scroll until the section "Summer";
  3. Interact with the SKU Selector;
  4. Observe that the item price is showing;

Screenshots or example usage:

Product Summary

ezgif com-gif-maker (1)

Product Page

Screen Shot 2020-12-02 at 17 31 13

How does this PR make you feel? 🔗

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 2, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@juliomoreira juliomoreira requested a review from dvm1984 December 2, 2020 21:04
@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@juliomoreira
Copy link
Contributor Author

Related to Issue: #875

docs/SKUSelector.md Outdated Show resolved Hide resolved
Comment on lines +26 to +27
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed now. Run vtex setup --typings and you should be good to go

Copy link
Contributor

@icazevedo icazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new prop should not be a boolean, but an enum. Maybe with 'current' as a possible value, that would indicate that it will show the current prince, and being possibly undefined (default case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants