fix: specify globals
as a required peer dependency
#1299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this plugin imports
globals
directly at runtime it should specify it as a dependency - technically, it could be a standard dependency, but I've gone with specifying it as a peer dependency to reduce maintenance burden and improve package deduplication, sincebrowser
group that this plugin uses) are very stableI have set v13.21.1 as the min. version allowed because that is a bugfix to address a rogue space in a property name that makes ESLint error, but technically most if not all versions of
globals
are compatible since thebrowser
group has been around for quite a whileResolves #1269