refactor: disable resolveType by default

vuejs · Jan 21, 2024 · e9c7e2c · e9c7e2c
1 parent 830fa7d
commit e9c7e2c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/packages/babel-plugin-jsx/src/index.ts b/packages/babel-plugin-jsx/src/index.ts
@@ -44,7 +44,7 @@ export default declare<VueJSXPluginOptions, BabelCore.PluginObj<State>>(
   (api, opt, dirname) => {
     const { types } = api;
     let resolveType: BabelCore.PluginObj<BabelCore.PluginPass> | undefined;
-    if (opt.resolveType !== false) {
+    if (opt.resolveType) {
       if (typeof opt.resolveType === 'boolean') opt.resolveType = {};
       resolveType = ResolveType(api, opt.resolveType, dirname);
     }

diff --git a/packages/babel-plugin-jsx/src/interface.ts b/packages/babel-plugin-jsx/src/interface.ts
@@ -25,7 +25,8 @@ export interface VueJSXPluginOptions {
   /** Replace the function used when compiling JSX expressions */
   pragma?: string;
   /**
-   * enabled by default
+   * (**Experimental**) Infer component metadata from types (e.g. `props`, `emits`, `name`)
+   * @default false
    */
   resolveType?: Options | boolean;
 }
diff --git a/packages/babel-plugin-jsx/test/__snapshots__/snapshot.test.ts.snap b/packages/babel-plugin-jsx/test/__snapshots__/snapshot.test.ts.snap
@@ -188,8 +188,6 @@ const A = defineComponent({
   }) {
     return () => _createVNode("span", null, [slots.default()]);
   }
-}, {
-  name: "A"
 });
 const _a2 = 2;
 a = _a2;

diff --git a/packages/babel-plugin-jsx/test/resolve-type.test.tsx b/packages/babel-plugin-jsx/test/resolve-type.test.tsx
@@ -12,7 +12,10 @@ describe('resolve type', () => {
         const App = defineComponent((props: Props) => <div />)
         `,
         {
-          plugins: [[typescript, { isTSX: true }], VueJsx],
+          plugins: [
+            [typescript, { isTSX: true }],
+            [VueJsx, { resolveType: true }],
+          ],
         }
       );
       expect(result!.code).toMatchSnapshot();