Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): fix nonHydratedAsyncRoot update and execution timing #11622

Closed
wants to merge 2 commits into from

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #11617

Copy link

github-actions bot commented Aug 15, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 98.7 kB (-1 B) 37.4 kB (-1 B) 33.7 kB (-55 B)
vue.global.prod.js 156 kB (-1 B) 57.2 kB (-1 B) 50.8 kB (-94 B)

Usages

Name Size Gzip Brotli
createApp 54.1 kB (-1 B) 21 kB (+1 B) 19.1 kB (-40 B)
createSSRApp 58.1 kB (-1 B) 22.6 kB (+3 B) 20.6 kB (+6 B)
defineCustomElement 58.8 kB (-1 B) 22.5 kB (+1 B) 20.5 kB (-1 B)
overall 67.7 kB (-1 B) 26 kB (-1 B) 23.7 kB (+93 B)

@yangxiuxiu1115
Copy link
Contributor Author

maybe queueJob(() => update()) is better.
It looks like calling update multiple times is due to an event loop problem. instance.asyncDep.catch().thent() will execute after two ticks, while instance.then() has only one tick

@edison1105
Copy link
Member

@yangxiuxiu1115

Thank you for the PR. There is already an existing PR #11619.
I believe that if there is an existing PR that has addressed the issue and its changes are almost correct, we should review it rather than submit a new one, unless the existing PR does not address the problem correctly. This approach is more contributor-friendly and easier for maintainers to manage.

@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/suspense branch August 15, 2024 08:56
@yangxiuxiu1115
Copy link
Contributor Author

I realized that #11619 didn't solve the problem so I submitted this PR, but the commit history for #11619 has related commits. I've closed this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async Component inside Suspense doesn't receive prop update
2 participants