Skip to content

feat(runtime-vapor): v-html and v-text work with component #13496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: minor
Choose a base branch
from
Open

feat(runtime-vapor): v-html and v-text work with component #13496

wants to merge 7 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jun 19, 2025 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Jun 19, 2025 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit a64867a
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/6853830cd05a530008d8f931
😎 Deploy Preview https://deploy-preview-13496--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 19, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vhtmlAndvTextWithDynamicComponent

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 19, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13496

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13496

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13496

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13496

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13496

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13496

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13496

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13496

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13496

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13496

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13496

vue

npm i https://pkg.pr.new/vue@13496

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13496

commit: 7fc2d6d

@edison1105 edison1105 added the scope: vapor related to vapor mode label Jun 19, 2025
Base automatically changed from vapor to minor July 7, 2025 00:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.6 kB 25.9 kB 23.6 kB
createVaporApp 20.9 kB 8.26 kB 7.57 kB
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

@LittleSound LittleSound mentioned this pull request Jul 22, 2025
Open
23 tasks
alex-snezhko
alex-snezhko reviewed Sep 17, 2025
View reviewed changes
@edison1105 edison1105 force-pushed the edison/fix/vhtmlAndvTextWithDynamicComponent branch from 396fa2a to da45770 Compare September 18, 2025 09:15
@edison1105 edison1105 changed the title feat(runtime-vapor): dynamic components work with v-html and v-text feat(runtime-vapor): v-html and v-text work with component Sep 18, 2025
alex-snezhko
alex-snezhko reviewed Sep 19, 2025
View reviewed changes
packages/runtime-vapor/src/dom/prop.ts
} else if (isVaporComponent(block)) {
setTextToBlock(block.block, value)
} else if (isArray(block)) {
if (__DEV__) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a scenario where this could be a single-element array i.e. in which setTextToBlock(block[0], value) could be used? Likewise with setHtmlToBlock

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior here is aligned with vdom's behavior: as long as it's an array, a warning is issued.

see playground

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense!

@edison1105 edison1105 moved this to Vapor in Next Minor Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alex-snezhko alex-snezhko alex-snezhko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
scope: vapor related to vapor mode version: minor
Projects
Next Minor
Status: Vapor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edison1105 @alex-snezhko