Skip to content

fix(runtime-core): pass props and children to loadingComponent #13997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2025
+4 −1
Merged

fix(runtime-core): pass props and children to loadingComponent #13997

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9498a8b
Pass props and children to loadingComponent
indykoning Oct 17, 2025
702adcb
Added types
indykoning Oct 17, 2025
f2155e2
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 2, 2025
ced1bf2
Merge branch 'main' into patch-1
edison1105 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/runtime-core/src/apiAsyncComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
error: error.value,
})
} else if (loadingComponent && !delayed.value) {
return createVNode(loadingComponent)
return createInnerComp(loadingComponent, instance)

Check failure on line 244 in packages/runtime-core/src/apiAsyncComponent.ts

View workflow job for this annotation

GitHub Actions / test / lint-and-test-dts 

Argument of type 'Component' is not assignable to parameter of type 'ConcreteComponent'.
}
}
},
Expand Down
Loading