-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Added support for Bun #630
base: main
Are you sure you want to change the base?
Conversation
@mchao123 Thanks for the PR @haoqunjiang Is this something we want to support as an option and yet another feature to maintain? Or could we just add a note in the README instead (as, IIUC, this just requires users to use a specific tsconfig file?). |
I'm open to add bun support considering it's low-effort. But I don't think we need yet another option to show to every user. User-agent detection should suffice. |
Some people prefer to use yarn or pnpm to manage their project creation. |
But I don’t think that’s a common enough use case for us to support. |
It's been a long time has there been an update on this?I always need to do some extra work after creating a project in order to adapt to bun, it would be great if this was supported at creation time, thank you guys. |
@mchao123 I think the user-agent detection proposition from @haoqunjiang is a good one: not too much maintenance work, and not another prompt for users. Feel free to ping us when you'll have reworked the PR 👍 |
Ok, I'll close this PR and finish this modification based on the latest branch again. |
I've made the change to show the runtime checkbox only when the user carries the parameter "--runtime".Maintaining a proprietary version of a package only requires creating a new directory in the others-runtime folder. |
Added support for Bun, added runtime selectors.
This is a tentative change that may require a review of the code.