Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow attaching block off instances #213

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Feb 16, 2022

Description

This PR will allow you to attach block storage from instances. This works well but does cause a little bit of drift but gets cleaned up on a apply or refresh. We will need to update the docs saying that this can be a bit drifty and it may be recommended to only use this if you must and if you do to ignore the attached_instance_to field on block.

Here is an example tf

resource "vultr_block_storage" "my_blockstorage" {
    size_gb = 10
    region = "ewr"
}


resource "vultr_block_storage" "bs2" {
    size_gb = 10
    region = "ewr"
}


resource "vultr_block_storage" "bs3" {
    size_gb = 10
    region = "ewr"
}


resource "vultr_instance" "prod-1" {
  region = "ewr"
  plan = "vhf-1c-2gb"
  os_id = 167
  block_storage_ids = [vultr_block_storage.bs2.id]
}

Once we test this a bit more I'll update the docs portion for instances

Related Issues

#176

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@Oogy
Copy link
Contributor

Oogy commented Oct 31, 2023

@optik-aper Please remove me from reviewers on this 🙏🏻

@optik-aper optik-aper requested review from optik-aper and removed request for Oogy October 31, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants