Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert vultr-node to typescript (Fixes #393) #754

Closed
wants to merge 2 commits into from

Conversation

skooch
Copy link

@skooch skooch commented Oct 18, 2023

Description

Converted the codebase to typescript. I've not moved the tests over, but they work.

A reviewer probably should:

  • Actually try to interact with the API with the library (I haven't had time yet)
  • Look at the strange syntax changes I (fixed?) in firewall.ts and make sure they're intended
  • Review types.ts, index.ts and utils.ts as this is where the most changes actually are

Related Issues

#393

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@github-actions
Copy link

Unit Tests and Coverage

Show Output

@vultr/[email protected] test
jest

-----------------------|---------|----------|---------|---------|-------------------

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 98.42 95.69 89.65 98.42
src 93.81 94.02 80 93.81
index.js 100 100 100 100
util.js 85 87.5 75 85 66-75,93
src/api 100 100 100 100
account.js 100 100 100 100
applications.js 100 100 100 100
backups.js 100 100 100 100
bare-metal.js 100 100 100 100
billing.js 100 100 100 100
block-storage.js 100 100 100 100
databases.js 100 100 100 100
dns.js 100 100 100 100
firewall.js 100 100 100 100
instances.js 100 100 100 100
iso.js 100 100 100 100
kubernetes.js 100 100 100 100
load-balancers.js 100 100 100 100
object-storage.js 100 100 100 100
operating-systems.js 100 100 100 100
plans.js 100 100 100 100
regions.js 100 100 100 100
registries.js 100 100 100 100
reserved-ips.js 100 100 100 100
snapshots.js 100 100 100 100
ssh-keys.js 100 100 100 100
startup-scripts.js 100 100 100 100
users.js 100 100 100 100
vpc2.js 100 100 100 100
vpcs.js 100 100 100 100
test 100 100 100 100
config.js 100 100 100 100
util.js 100 100 100 100
----------------------- --------- ---------- --------- --------- -------------------
*Pusher: @skooch, Action: `pull_request_target`*

@optik-aper optik-aper added the enhancement New feature or request label Oct 18, 2023
@github-actions
Copy link

Unit Tests and Coverage

Show Output

@vultr/[email protected] test
jest

-----------------------|---------|----------|---------|---------|-------------------

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 98.42 95.69 89.65 98.42
src 93.81 94.02 80 93.81
index.js 100 100 100 100
util.js 85 87.5 75 85 66-75,93
src/api 100 100 100 100
account.js 100 100 100 100
applications.js 100 100 100 100
backups.js 100 100 100 100
bare-metal.js 100 100 100 100
billing.js 100 100 100 100
block-storage.js 100 100 100 100
databases.js 100 100 100 100
dns.js 100 100 100 100
firewall.js 100 100 100 100
instances.js 100 100 100 100
iso.js 100 100 100 100
kubernetes.js 100 100 100 100
load-balancers.js 100 100 100 100
object-storage.js 100 100 100 100
operating-systems.js 100 100 100 100
plans.js 100 100 100 100
regions.js 100 100 100 100
registries.js 100 100 100 100
reserved-ips.js 100 100 100 100
snapshots.js 100 100 100 100
ssh-keys.js 100 100 100 100
startup-scripts.js 100 100 100 100
users.js 100 100 100 100
vpc2.js 100 100 100 100
vpcs.js 100 100 100 100
test 100 100 100 100
config.js 100 100 100 100
util.js 100 100 100 100
----------------------- --------- ---------- --------- --------- -------------------
*Pusher: @skooch, Action: `pull_request_target`*

@AFatalErrror
Copy link
Contributor

Awesome, thanks! Ill take a look soon.

@skooch
Copy link
Author

skooch commented Nov 14, 2023

Awesome, thanks! Ill take a look soon.

How soon?

@AFatalErrror
Copy link
Contributor

We appreciate the PR, but we're going to keep this repo as node(js) and create a new typescript repo. If you want to contribute to that we can follow up with you when that's underway

@skooch
Copy link
Author

skooch commented Nov 19, 2023

Thanks for the update @AFatalErrror. Do you know when this might be happening? I may just fork if there's no timeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants