Skip to content

feat: don't display tests that pass on terminal output to reduce debugging noise #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vyadh merged 2 commits into from
Dec 26, 2025
Merged

feat: don't display tests that pass on terminal output to reduce debugging noise #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d42e76c
feat: don't display PASS by default on terminal output to aid debuggi…
vyadh Dec 26, 2025
287e74a
chore: bumped actions/checkout to v6
vyadh Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ${{ matrix.platform }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Install Nushell Binary
uses: hustcer/setup-nu@v3
Expand Down Expand Up @@ -103,10 +103,10 @@ jobs:
runs-on: ${{ matrix.platform }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Checkout Nushell
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
repository: nushell/nushell
ref: main
Expand Down
15 changes: 9 additions & 6 deletions nutest/display/display_terminal.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,16 @@ def complete-test [theme: closure, formatter: closure]: record -> nothing {
error make { msg: $"No test results found for: ($event)" }
}
let row = $result | first
let formatted = format-result $row.result $theme

if ($row.output | is-not-empty) {
let output = $row.output | format-output $formatter
print $"($formatted) ($suite) ($test)\n($output)"
} else {
print $"($formatted) ($suite) ($test)"
if $row.result != "PASS" {
let formatted = format-result $row.result $theme

if ($row.output | is-not-empty) {
let output = $row.output | format-output $formatter
print $"($formatted) ($suite) ($test)\n($output)"
} else {
print $"($formatted) ($suite) ($test)"
}
}
}

Expand Down
Loading