dhcpv6-server: T3493: adds prefix range validation and fixes typos in…#3499
Merged
c-po merged 1 commit intovyos:sagittafrom May 22, 2024
Merged
dhcpv6-server: T3493: adds prefix range validation and fixes typos in…#3499c-po merged 1 commit intovyos:sagittafrom
c-po merged 1 commit intovyos:sagittafrom
Conversation
… select ConfigError messages
c-po
approved these changes
May 22, 2024
sarthurdev
approved these changes
May 22, 2024
This was referenced May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… select ConfigError messages
Change Summary
Adds detection for when prefix-delegation start and prefix-delegation stop addresses are not within the IPv6 subnet defined. A ConfigError message is raised for both cases.
Updates typos in select ConfigError messages (e.g. then -> than, multipe -> multiple)
Types of changes
Related Task(s)
https://vyos.dev/T3493
Related PR(s)
Component(s) name
dhcpv6-server service
Proposed changes
How to test
Test 1 - that prefix start address is not within subnet
Output:
Prefix delegation start address "2001:db8:290::500" is not in subnet
"2001:db8:3456::/64"
Test 2 - that prefix stop address is not within subnet
Output:
Prefix delegation stop address "2001:db8:290::5ff" is not in subnet
"2001:db8:3456::/64"
Smoketest result
Checklist: