Skip to content

smoketest: T8087: reorganize folderstructure for embedded configttests #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
c-po merged 1 commit into from
Dec 11, 2025
Merged

smoketest: T8087: reorganize folderstructure for embedded configttests #4893

c-po merged 1 commit into from
Dec 11, 2025
+85 −10

Conversation

@c-po
Copy link
Member

@c-po c-po commented Dec 10, 2025 •
edited
Loading

Change summary

Configuration files for config tests gathered from lab installations, customers or our own networks were placed in multiple directories - all related to the same thing.

We have had config-tests, configs and config.no-load. This commit re-arranges all the files and places a proper README for the users.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

make testc

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions
Copy link

github-actions bot commented Dec 10, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Dec 10, 2025
@c-po
smoketest: T8087: reorganize folderstructure for embedded configttests
e2e35c9 
Configuration files for config tests gathered from lab installations, customers
or our own networks were placed in multiple directories - all related to
the same thing.

We have had config-tests, configs and config.no-load. This commit re-arranges
all the files and places a proper README for the users.
jestabro
jestabro approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@jestabro jestabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement to the organization of config test files, with a lucid README added.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests ❌ failed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

sever-sever
sever-sever approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoketests files/directiories structure refactoring without functional changes.
VPP config load fails, because it was not excluded from "match" and requires additional change "cleanup" here https://github.com/vyos/vyos-build/blob/39d836a15cee1db6304c6d1470e9d5fbb4280b05/scripts/check-qemu-install#L962-L973

New structure is more clear. Readme as well.

alexandr-san4ez
alexandr-san4ez approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@alexandr-san4ez alexandr-san4ez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are well structured and ready to be merged. It is a good update. 👍

sarthurdev
sarthurdev approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes test paths more clear to understand and adds test documentation.

Config tests confirmed working.

@c-po c-po mentioned this pull request Dec 11, 2025
Merged
11 tasks
@c-po c-po enabled auto-merge December 11, 2025 15:11
@c-po c-po disabled auto-merge December 11, 2025 15:11
@c-po c-po merged commit 2496b8a into vyos:current Dec 11, 2025
18 of 19 checks passed
@c-po c-po deleted the configtests branch December 11, 2025 15:11
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarthurdev sarthurdev sarthurdev approved these changes

@jestabro jestabro jestabro approved these changes

@sever-sever sever-sever sever-sever approved these changes

+1 more reviewer

@alexandr-san4ez alexandr-san4ez alexandr-san4ez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@c-po c-po

Labels

bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current mirror-completed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@c-po @sarthurdev @jestabro @sever-sever @alexandr-san4ez @vyosbot