Skip to content

Conversation

@c-po
Copy link
Member

@c-po c-po commented Dec 10, 2025

Change summary

There is a CLI constraint for lowercase country codes, but user's do not see this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

How to test / Smoketest result

vyos@vyos# set firewall ipv4 name foo rule 10 source geoip country-code
Possible completions:
   <country>            Country code (2 characters, lowercase)
   ad
   ae
   af
   ...
vyos@vyos# set firewall ipv6 name foo rule 10 source geoip country-code
Possible completions:
   <country>            Country code (2 characters, lowercase)
   ad
   ae
   af
   ...

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

👍
No issues in PR Title / Commit Title

There is a CLI constraint for lowercase country codes, but user's do not
see this.
@github-actions
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests ❌ failed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add completion help for the geip country codes.

Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds completion helper for country-code values. Works as expected.

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about the IO code since the isles are being transferred to Mauritius, but it's not done yet so there's no reason to exclude the country code.

@dmbaturin dmbaturin merged commit aa3b597 into vyos:current Dec 11, 2025
18 of 19 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current mirror-completed

Development

Successfully merging this pull request may close these issues.

6 participants