-
Notifications
You must be signed in to change notification settings - Fork 395
firewall: T8089: "geoip country-code" should get a completion helper #4894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 |
There is a CLI constraint for lowercase country codes, but user's do not see this.
|
CI integration ❌ failed! Details
|
sever-sever
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add completion help for the geip country codes.
sarthurdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds completion helper for country-code values. Works as expected.
dmbaturin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about the IO code since the isles are being transferred to Mauritius, but it's not done yet so there's no reason to exclude the country code.
Change summary
There is a CLI constraint for lowercase country codes, but user's do not see this.
Types of changes
Related Task(s)
How to test / Smoketest result
Checklist: