Fix change detection for recent Vyos versions #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Recent Vyos versions started returning this for no-change
compare saved
output:instead of just
[edit]
. This causesvyos_config
to always return achanged
result. This PR fixes the issue by properly detecting both cases.Types of changes
Related Task(s)
N/A
Related PR(s)
N/A
Proposed changes
See "Change Summary" section.
How to test
Point my Ansible code to use a version of
vyos.vyos
with this patch inrequirements.txt
, runansible-galaxy install -r requirements.yml --force
, and verify thatvyos_config
now properly returnsok
instead ofchanged
when there are no changes.Checklist: