wip: implement methods for structs #4041
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from vyper.codegen.core import _freshname, eval_once_check, make_setter | ||
| from vyper.codegen.ir_node import IRnode | ||
| from vyper.evm.address_space import MEMORY | ||
| from vyper.exceptions import StateAccessViolation | ||
| from vyper.semantics.types.function import MemberFunctionT |
Check notice
Code scanning / CodeQL
Cyclic import Note
| @@ -19,6 +19,7 @@ | |||
| from vyper.semantics.analysis.utils import check_modifiability, validate_expected_type | |||
| from vyper.semantics.data_locations import DataLocation | |||
| from vyper.semantics.types.base import VyperType | |||
| from vyper.semantics.types.function import MemberFunctionT | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
test contract:
```
struct Foo:
user: address
balance: uint256
def decrement_balance(self, amount: uint256):
self.balance -= amount
@external
def foo(f: Foo):
s: Foo = f
s.decrement_balance(1)
```
charles-cooper
force-pushed
the
feat/struct-methods
branch
from
e153e25
to
d94f548
Compare
|
A few examples of the intended use might be nice to see for commenting on the implementation |
check commit message - d94f548 |
@external
def foo(f: Foo):
s: Foo = f
s.decrement_balance(1)
|
i thought about it, i think additional syntax is overkill. it depends more just on the location of the item, like if you can do |
so you would be able to call a non-mutable method on |
What I did
just messing around, opening the PR so others can follow progress
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture