Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[codegen]: simplify external call unpacker #4146

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

simplify external call unpacker. this has the semantic result of an extra memory copy when decoding needs_clamp=False data, but hopefully in the future we can optimize that out in the optimizer.

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

simplify external call unpacker. this has the semantic result of an
extra memory copy when decoding needs_clamp=False data, but hopefully in
the future we can optimize that out in the optimizer.
@charles-cooper charles-cooper added this to the v0.4.1 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant