Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[codegen]: fix false positive in risky call detection #4160

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix[codegen]: fix false positive in risky call detection #4160

wants to merge 5 commits into from

Commits on Jun 20, 2024

  1. fix[codegen]: fix false positive in contains_risky_call 

    the `potential_overlap` and `read_write_overlap()` functions use
`contains_risky_call` to detect if there is potential for reentrancy.
however, when the target is a precompile, there is no chance for
reentrancy, so we filter them out of the detector.
    @charles-cooper
    charles-cooper committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b32c1d6 View commit details
    Browse the repository at this point in the history

  2. add tests 

    ---------

Co-authored-by: Hubert Ritzdorf <[email protected]>
Co-authored-by: trocher <[email protected]>
    @charles-cooper @trocher
    3 people committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d950f1b View commit details
    Browse the repository at this point in the history

  3. add a comment

    @charles-cooper
    charles-cooper committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3c62295 View commit details
    Browse the repository at this point in the history

  4. rename a property

    @charles-cooper
    charles-cooper committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6520537 View commit details
    Browse the repository at this point in the history

  5. add print to safe precompiles

    @charles-cooper
    charles-cooper committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    48132c9 View commit details
    Browse the repository at this point in the history