Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: scheduler optimization #4161

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Jun 20, 2024

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

vyper/venom/__init__.py Fixed Show fixed Hide fixed
vyper/venom/passes/dft.py Fixed Show fixed Hide fixed
Comment on lines +208 to +211
# if bb.label.value == "__main_entry" and count == 1:
# print(self.gda_as_graph())
# import sys
# sys.exit(1)

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 15.21739% with 195 lines in your changes missing coverage. Please review.

Project coverage is 45.79%. Comparing base (e9db8d9) to head (21e20c7).

Current head 21e20c7 differs from pull request most recent head 78b0aac

Please upload reports for the commit 78b0aac to get more accurate results.

Files Patch % Lines
vyper/venom/passes/dft.py 12.71% 151 Missing ⚠️
vyper/utils.py 4.34% 22 Missing ⚠️
vyper/venom/basicblock.py 33.33% 18 Missing ⚠️
vyper/venom/__init__.py 60.00% 2 Missing ⚠️
vyper/venom/analysis/analysis.py 0.00% 1 Missing ⚠️
vyper/venom/analysis/cfg.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e9db8d9) and HEAD (21e20c7). Click for more details.

HEAD has 201 uploads less than BASE | Flag | BASE (e9db8d9) | HEAD (21e20c7) | |------|------|------| ||202|1|
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4161       +/-   ##
===========================================
- Coverage   91.37%   45.79%   -45.59%     
===========================================
  Files         109      109               
  Lines       15606    15799      +193     
  Branches     3432     3486       +54     
===========================================
- Hits        14260     7235     -7025     
- Misses        916     8007     +7091     
- Partials      430      557      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants