-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[venom]: remove dloadbytes
and sha3_64
venom instructions
#4325
Conversation
I think that we want |
We can always add them when we need them -and we know the exact requirements- |
i think we need them, zksync handles immutables as storage variables. |
Since zkSync currently does not support Venom, merging this will not cause any disruptions. Furthermore, dstore was never part of Venom to begin with. To properly support zkSync or other architectures, we would need a command-line parameter for architecture selection. A less invasive approach would be to treat it as a special version of the EVM, although this isn't ideal. Venom will utilize architecture-specific information to decide which opcodes are permissible (or required) and even to choose more efficient opcodes on architectures where gas consumption varies, etc. |
Added an issue about it #4326 |
Check #4357 |
i think we could even keep this open, since the other PR is more concerned with the frontend generating the instructions in the first place |
the dloadbytes portion is superseded by #4410. let's leave this open for the sha3_64 change, although i think it can help with cse and instruction reordering |
What I did
Remove
dloadbytes
andsha3_64
venom instructions, and updated the translator to emit directly lower level instructions.How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture