Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ux]: syntax exception missing filename #4343

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sandbubbles
Copy link
Collaborator

What I did

Print filename for syntax exceptions as in #4285.

How I did it

Rethrow syntax exceptions from a point where path is known (two places - one for natspec, one for the rest).

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 46.08%. Comparing base (fcddb70) to head (67dcfb8).

Files with missing lines Patch % Lines
vyper/ast/parse.py 50.00% 3 Missing ⚠️
vyper/compiler/phases.py 50.00% 3 Missing ⚠️
vyper/exceptions.py 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fcddb70) and HEAD (67dcfb8). Click for more details.

HEAD has 138 uploads less than BASE
Flag BASE (fcddb70) HEAD (67dcfb8)
139 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4343       +/-   ##
===========================================
- Coverage   91.35%   46.08%   -45.28%     
===========================================
  Files         112      112               
  Lines       15923    15937       +14     
  Branches     2691     2692        +1     
===========================================
- Hits        14546     7344     -7202     
- Misses        942     8036     +7094     
- Partials      435      557      +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant