Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: add calloca instruction #4376

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Nov 26, 2024

What I did

promote the callee buffer (allocated at call site) to an alloca-like instruction.

there are a couple minor regressions in here:
one is fixed in #4419
the other is filed in #4420.

How I did it

How to verify it

Commit message

this commit promotes the callee buffer (allocated at call site) to an
alloca-like instruction, `calloca`. this allows us to treat all buffers
generated by the frontend abstractly, instead of needing to do memory
analysis.

`calloca` additionally has a parameter to help identify which call-site
it is associated with, as a hint for alias and reordering analyses.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

this instruction is meant to help match call-site allocations with
pallocas (inside the callee).
@charles-cooper charles-cooper requested a review from harkal December 4, 2024 11:51
@charles-cooper charles-cooper marked this pull request as ready for review December 7, 2024 15:14
@charles-cooper charles-cooper requested review from harkal and removed request for harkal December 7, 2024 15:15
@charles-cooper charles-cooper added this to the v0.4.1 milestone Dec 18, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.02%. Comparing base (c208b95) to head (319ddd4).

Files with missing lines Patch % Lines
vyper/venom/venom_to_assembly.py 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4376      +/-   ##
==========================================
+ Coverage   92.01%   92.02%   +0.01%     
==========================================
  Files         119      119              
  Lines       16692    16724      +32     
  Branches     2805     2810       +5     
==========================================
+ Hits        15359    15391      +32     
  Misses        915      915              
  Partials      418      418              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants