feat[venom]: disable legacy optimizer in the venom pipeline #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit disables the legacy optimizer when the venom pipeline is enabled. this should make the pipeline faster and removes the "training wheels" for venom (since we can't depend on optimizations in the legacy pipeline).
|
marking this as draft since it introduces regressions. should be in a much better place once #4281 is merged. |
This reverts commit f0df458. don't always disable since it breaks tests and potentially other functionality. we will disable at the relevant call sites.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4411 +/- ##
==========================================
+ Coverage 88.29% 89.01% +0.72%
==========================================
Files 116 116
Lines 16475 16475
Branches 2777 2777
==========================================
+ Hits 14547 14666 +119
+ Misses 1388 1300 -88
+ Partials 540 509 -31 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit disables the legacy optimizer when the venom pipeline is enabled. this should make the pipeline faster and removes the "training wheels" for venom (since we can't depend on optimizations in the legacy pipeline).
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture