refactor[lang]: remove VyperNode __hash__() and __eq__() implementations

tests/unit/ast/nodes/test_binary.py

@@ -1,5 +1,6 @@
 import pytest
 
+from tests.ast_utils import deepequals
 from vyper import ast as vy_ast
 from vyper.exceptions import SyntaxException
 
@@ -18,7 +19,7 @@ def x():
     """
     )
 
-    assert expected == mutated
+    assert deepequals(expected, mutated)
 
 
 def test_binary_length():

tests/unit/ast/nodes/test_compare_nodes.py

@@ -1,3 +1,4 @@
+from tests.ast_utils import deepequals
 from vyper import ast as vy_ast
 
 
@@ -6,33 +7,33 @@ def test_compare_different_node_clases():
     left = vyper_ast.body[0].target
     right = vyper_ast.body[0].value
 
-    assert left != right
+    assert not deepequals(left, right)
 
 
 def test_compare_different_nodes_same_class():
     vyper_ast = vy_ast.parse_to_ast("[1, 2]")
     left, right = vyper_ast.body[0].value.elements
 
-    assert left != right
+    assert not deepequals(left, right)
 
 
 def test_compare_different_nodes_same_value():
     vyper_ast = vy_ast.parse_to_ast("[1, 1]")
     left, right = vyper_ast.body[0].value.elements
 
-    assert left != right
+    assert not deepequals(left, right)
 
 
 def test_compare_similar_node():
     # test equality without node_ids
     left = vy_ast.Int(value=1)
     right = vy_ast.Int(value=1)
 
-    assert left == right
+    assert deepequals(left, right)
 
 
 def test_compare_same_node():
     vyper_ast = vy_ast.parse_to_ast("42")
     node = vyper_ast.body[0].value
 
-    assert node == node
+    assert deepequals(node, node)

tests/unit/ast/test_ast_dict.py

@@ -1,6 +1,7 @@
 import copy
 import json
 
+from tests.ast_utils import deepequals
 from vyper import compiler
 from vyper.ast.nodes import NODE_SRC_ATTRIBUTES
 from vyper.ast.parse import parse_to_ast
@@ -138,7 +139,7 @@ def test() -> int128:
     new_dict = json.loads(out_json)
     new_ast = dict_to_ast(new_dict)
 
-    assert new_ast == original_ast
+    assert deepequals(new_ast, original_ast)
 
 
 # strip source annotations like lineno, we don't care for inspecting

tests/unit/ast/test_parser.py

@@ -1,3 +1,4 @@
+from tests.ast_utils import deepequals
 from vyper.ast.parse import parse_to_ast
 
 
@@ -12,7 +13,7 @@ def test() -> int128:
     ast1 = parse_to_ast(code)
     ast2 = parse_to_ast("\n   \n" + code + "\n\n")
 
-    assert ast1 == ast2
+    assert deepequals(ast1, ast2)
 
 
 def test_ast_unequal():
@@ -32,4 +33,4 @@ def test() -> int128:
     ast1 = parse_to_ast(code1)
     ast2 = parse_to_ast(code2)
 
-    assert ast1 != ast2
+    assert not deepequals(ast1, ast2)

vyper/ast/nodes.py

@@ -339,17 +339,9 @@
         # default implementation of deepcopy is a hotspot
         return pickle.loads(pickle.dumps(self))
 
-    def __eq__(self, other):
-        # CMC 2024-03-03 I'm not sure it makes much sense to compare AST
-        # nodes, especially if they come from other modules
-        if not isinstance(other, type(self)):
-            return False
-        if getattr(other, "node_id", None) != getattr(self, "node_id", None):
-            return False
-        for field_name in (i for i in self.get_fields() if i not in VyperNode.__slots__):
-            if getattr(self, field_name, None) != getattr(other, field_name, None):
-                return False
-        return True
+    def __ne__(self, other):
+        # temporary to suss out all instances of != in tests
+        raise Exception()
 
     def __repr__(self):
         cls = type(self)

vyper/semantics/analysis/imports.py

@@ -58,7 +58,7 @@ def push_path(self, module_ast: vy_ast.Module) -> None:
 
     def pop_path(self, expected: vy_ast.Module) -> None:
         popped = self._path.pop()
-        if expected != popped:
+        if expected is not popped:  # FIXME - use expected != popped
             raise CompilerPanic("unreachable")
         self._imports.pop()