chore[ci]: bump upload-artifact action to v4

[tserg]

What I did

Fix #4441.

How I did it

How to verify it

Commit message

This commit bumps the upload-artifact action to v4 because
v3 will be deprecated on 30 Jan 2025.

Description for the changelog

Bump upload-artifact action to v4

Cute Animal Picture

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (f444c8f) to head (baba209).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files         119      119           
  Lines       16686    16686           
  Branches     2808     2808           
=======================================
  Hits        15348    15348           
  Misses        919      919           
  Partials      419      419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tserg]

How can I test this?

vyper/.github/workflows/build.yml

Lines 101 to 115 in 9db1546

	# TODO: this needs to be tested when upgrading to upload-artifact v4
	working-directory: artifacts/artifact
	run: |
	set -Eeuxo pipefail
	for BIN_NAME in $(ls)
	do
	curl -L \
	--no-progress-meter \
	-X POST \
	-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"\
	-H "Content-Type: application/octet-stream" \
	"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME/+/%2B}" \
	--data-binary "@${BIN_NAME}"
	done

[charles-cooper]

How can I test this?

vyper/.github/workflows/build.yml

Lines 101 to 115 in 9db1546

	# TODO: this needs to be tested when upgrading to upload-artifact v4
	working-directory: artifacts/artifact
	run: |
	set -Eeuxo pipefail
	for BIN_NAME in $(ls)
	do
	curl -L \
	--no-progress-meter \
	-X POST \
	-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"\
	-H "Content-Type: application/octet-stream" \
	"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME/+/%2B}" \
	--data-binary "@${BIN_NAME}"
	done

check the build artifacts actions -- ex. https://github.com/vyperlang/vyper/actions/runs/12720146923/job/35461412257?pr=4445

[tserg]

I have made some changes and verified it is working.

[charles-cooper]

this looks good, we should merge before the next rc