Allow an order placing when business ID or VAT number validation fail…

…s for technical reasons (#72) * feature: allow an order creation when business ID or VAT number validation fails for technical reasons * feature: show VAT number verification notice on orders table, move the notification in admin e-mails below to e-mail header * update tests * fix: check stict type * do not use short echo tag * add HPOS support for order listing * add changelog --------- Co-authored-by: Pavel Vybíral <[email protected]> Co-authored-by: Karolína Vyskočilová <[email protected]>
vyskoczilova · Jun 28, 2024 · 68a447e · 68a447e
1 parent 18672bc
commit 68a447e
Show file tree

Hide file tree

Showing 14 changed files with 448 additions and 144 deletions.
diff --git a/README.md b/README.md
@@ -44,6 +44,8 @@ If you need to set it up in your theme or plugin, you can use following filters
 
     add_filter( 'woolab_icdic_vies_check', '__return_true' );
 
+    add_filter( 'woolab_icdic_ignore_check_fail', '__return_true' );
+
     add_filter( 'woolab_icdic_vat_exempt_enabled', function(){
       return "no"; // or "yes"
     } );

diff --git a/assets/js/admin.js b/assets/js/admin.js
@@ -7,9 +7,18 @@
     var vies_check = $('#woolab_icdic_vies_check');
 
     if (ares_check.length) {
-      enableActive(ares_check);
+      enableAresActive(ares_check);
+      enableIgnoreCheckFailActive(ares_check, vies_check);
       ares_check.change(function () {
-        enableActive(ares_check);
+        enableAresActive(ares_check);
+        enableIgnoreCheckFailActive(ares_check, vies_check);
+      });
+    }
+
+    if (vies_check.length) {
+      enableIgnoreCheckFailActive(ares_check, vies_check);
+      vies_check.change(function () {
+        enableIgnoreCheckFailActive(ares_check, vies_check);
       });
     }
 
@@ -31,7 +40,7 @@
     }
   });
 
-  function enableActive(ares_check) {
+  function enableAresActive(ares_check) {
     var active = $('#woolab_icdic_ares_fill');
 
     if (ares_check.prop("checked") == true) {
@@ -40,4 +49,14 @@
       active.prop("disabled", true).prop("checked", false);
     }
   }
+
+  function enableIgnoreCheckFailActive(ares_check, vies_check) {
+    var checkbox = $('#woolab_icdic_ignore_check_fail');
+
+    if (ares_check.prop('checked') || vies_check.prop('checked')) {
+      checkbox.prop('disabled', false);
+    } else {
+      checkbox.prop('disabled', true).prop('checked', false);
+    }
+  }
 })(jQuery);
diff --git a/assets/js/admin.min.js b/assets/js/admin.min.js
diff --git a/assets/js/public.js b/assets/js/public.js
@@ -233,6 +233,7 @@
 
                 if (woolab.ares_fill) {
                   // Compatibility with Fluid Checkout for WooCommerce – Lite
+                  // https://wordpress.org/support/topic/compatibility-with-kybernaut-ico-dic-plugin/
                   if ($('#billing_same_as_shipping') && $('#billing_same_as_shipping').is(':checked')) {
                     // Check whether the CollapsibleBlock library is available
                     if (window.CollapsibleBlock) {
@@ -290,7 +291,10 @@
                 }
 
                 ares_remove_disabled_from_input();
-                ico_class.append('<span role="alert" class="woolab-ic-dic-tip error">' + data.error + '</span>');
+
+                if (!data.internal_error || !woolab.ignore_check_fail) {
+                  ico_class.append('<span role="alert" class="woolab-ic-dic-tip error">' + data.error + '</span>');
+                }
               }
             } else {
               ares_error(ico_class);
@@ -325,11 +329,14 @@
 
   function ares_error(ico_class) {
     if (woolab.ares_fill) {
-      $('#billing_company').val('');
-      $('#billing_dic').val('');
-      $('#billing_postcode').val('');
-      $('#billing_city').val('');
-      $('#billing_address_1').val('');
+      if (!woolab.ignore_check_fail) {
+        $('#billing_company').val('');
+        $('#billing_dic').val('');
+        $('#billing_postcode').val('');
+        $('#billing_city').val('');
+        $('#billing_address_1').val('');
+      }
+
       ares_remove_disabled_from_input();
     }
 

diff --git a/assets/js/public.min.js b/assets/js/public.min.js
diff --git a/includes/ares.php b/includes/ares.php
@@ -32,7 +32,7 @@ function woolab_icdic_ares( $ico = '' ) {
             $body = wp_remote_retrieve_body($response);
             $data = json_decode($body);
 
-            if ( $status_code == 200 && $data ) {
+            if ( $status_code === 200 && $data ) {
 
                 $return = array( 'error' => false );
                 $return['spolecnost'] = $data->obchodniJmeno ?? '';
@@ -49,14 +49,20 @@ function woolab_icdic_ares( $ico = '' ) {
                 $return['psc'] = $data->sidlo->psc;
                 $return['mesto'] = $data->sidlo->nazevMestskehoObvodu ?? $data->sidlo->nazevObce;
 
-            } elseif ( $status_code == 404 ) {
+            } elseif ( $status_code === 404 ) {
                 $return = array( 'error' => __('Entity doesn\'t exist in ARES.', 'woolab-ic-dic'));
             } else {
-                $return = array( 'error' => __('ARES is not responding', 'woolab-ic-dic'));
+                $return = array(
+					'error'          => __('ARES is not responding.', 'woolab-ic-dic'),
+	                'internal_error' => true,
+                );
             }
 
         } else {
-            $return = array( 'error' => __('An error occured while connecting to ARES, try it again later.', 'woolab-ic-dic'));
+            $return = array(
+				'error'          => __('An error occured while connecting to ARES, try it again later.', 'woolab-ic-dic'),
+				'internal_error' => true,
+            );
         }
 
         return $return;