Fix tax class selection in dropdown not updating #73 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ondřej! Thanks a lot for the pull request and bug fix. I'll check it out on Friday/Monday (I'm OOO currently). I'll get back to you. Karolina |
|
This is weird, I can't fix the bug you're mentioning in #74 https://www.loom.com/share/a2b46b1ae80d4517a11264c146be7749. The proposed change is definitely worth implementing and I'll merge it, but I still wonder why the issue is not present on my end 🤔...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where users were unable to persistently select a tax class from the dropdown menu in the plugin settings. The selection would revert to the default option after saving due to a problem with how the tax class values were being handled.
Issue Related: This pull request refers to #73
I welcome any feedback on these changes and look forward to your review.