Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validVC fixture to vcdm 2.0 #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

PatStLouis
Copy link
Collaborator

No description provided.

@aljones15
Copy link
Contributor

the better way to handle this is probably just to let each suite pass in a fixture, the verifier tests already allow this. As this is a breaking release I suppose we probably should do this here, but it might be better to make a fixtures/ dir with a vc 1.1 and vc 2.0 validVc.json file.

@PatStLouis
Copy link
Collaborator Author

OK, I will look into this

@aljones15
Copy link
Contributor

aljones15 commented Aug 13, 2024

just so this is known: the issuer suites now accept a credential parameter so that issuer and verifier tests can be run with both VC versions 1.1 and 2.0. However, we can definitely still use this PR as it could provide both a 1.1 and 2.0 credential for other suites to use.

TODO:

  • export both VC 1.1 and VC 2.0 credentials
  • use those credentials in other suites that just require a basic VC test
  • optionally the valid VC could be updated to have something in the credential subject using an inline context (see the test fixtures for an example or the ecdsa-sd-2023 tests for examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants