Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial description of JWK production #56

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Jun 21, 2022

This PR adds some basic JWK production rules, links to the relevant RFCs and fractures the previous "spec only" issue, into 2 concrete new issues to track remaining work.

I suspect this is not the last PR to this section, I am attempting to keep the PR size low to enable more effective review.


Preview | Diff

Copy link
Collaborator

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs more detail, namely it needs to throw appropriate errors when encoding failures are detected. Merging anyway as it's better than what's in the spec right now, which is nothing.

@msporny msporny merged commit f5abee8 into main Sep 2, 2022
@msporny msporny deleted the feat/address-jwk-production-rules branch September 2, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants