Remove test cases that no longer verify as-is #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
approved these changes
Jan 25, 2022
|
@clehner thanks for this PR! |
mprorock
approved these changes
Jan 25, 2022
They no longer verify, due to changes in the Traceability Context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifiable credential test vectors 29 and 30 no longer verify as-is, because of changes in the Traceability context.
Re: #17 (comment)
Fix #16
Close #17
I'm unsure of how to go about regenerating these two test vectors or if that would be useful. I don't know if there is functionality that these are supposed to be testing that other test vectors do not already -- other than that they depend on a non-current version of a JSON-LD context file. I don't see if it is possible or helpful to switch these to negatives tests, i.e. to require that implementers use up-to-date context files. So this PR just removes these two test vectors (similarly to #15).