Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Workflow system in introduction, both to the diagram and the prose #353

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

jandrieu
Copy link
Contributor

@jandrieu jandrieu commented Dec 12, 2023

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There's an arrow labeled "receive verifiable credentials" that points from Holder Coordinator to Issuer Coordinator. I think this must point the other direction.
  • If the "Any Authorized Party" hexagon moves up, and the 3 "Workflow service" parallelograms move into the inner field with the "Any Authorized Party" hexagon, then the "use exchange" and "create exchange" arrows can all be shifted slightly, such that none of them cross each other.
  • If the "Holder" human moves left, and the "Storage Service (Holder)" cylinder moves into the triangle of "Holder" human, "Holder Coordinator" pentagon, and "Holder Admin" box, the "use wallet" and "configure" arrows between "Holder" human and "Holder Coordinator" pentagon and between "Holder" human and "Holder Admin" box can be adjusted somewhat to again make there be no crossings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Incoming graphic soon.

index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/ @TallTed's changes applied.

The diagram is getting to the point that we're going to have to refactor it. It gives the impression that the ecosystem is more complex than it is due to the crisscrossing lines.

@TallTed
Copy link
Collaborator

TallTed commented Jan 8, 2024

The diagram is getting to the point that we're going to have to refactor it. It gives the impression that the ecosystem is more complex than it is due to the crisscrossing lines.

Yes. Note that I've provided guidance for minor movements of existing elements that will eliminate all line crossings.

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 w/ @TallTed's suggestions.

@jandrieu
Copy link
Contributor Author

jandrieu commented Feb 6, 2024

@TallTed Fixes in.

Let me know if I got all of your suggestions on the diagram.

@jandrieu jandrieu requested a review from TallTed February 6, 2024 20:43
@msporny
Copy link
Contributor

msporny commented Feb 12, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 1b02fcd into w3c-ccg:main Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants