Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenAPI validity & publishing. #355

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix OpenAPI validity & publishing. #355

merged 2 commits into from
Jan 9, 2024

Conversation

BigBlueHat
Copy link
Collaborator

  • Remove unused NotifyPresentationAvailableResponse.
  • Fix openapi bundling.

@BigBlueHat
Remove unused NotifyPresentationAvailableResponse.
5391b92 
Unused model in OpenAPI definition for holder.
@BigBlueHat
Fix openapi bundling.
d6c6db3 
This should fix the OpenAPI documents not being published properly as well.
@BigBlueHat
Copy link
Collaborator Author

FWIW, NotifyPresentationAvailableResponse is only present in the OpenAPI files and not in the current spec. So, removing it should be fine. However, I'd love a 👍 from someone before merging this...just in case. 😃

@msporny msporny merged commit 72de201 into w3c-ccg:main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@dlongley dlongley dlongley approved these changes

@mavarley mavarley Awaiting requested review from mavarley mavarley is a code owner

@mkhraisha mkhraisha Awaiting requested review from mkhraisha mkhraisha is a code owner

@jandrieu jandrieu Awaiting requested review from jandrieu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BigBlueHat @msporny @dlongley