Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /challenges endpoint. #373

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Add /challenges endpoint. #373

merged 5 commits into from
Mar 26, 2024

Conversation

wes-smith
Copy link
Collaborator

@wes-smith wes-smith commented Feb 28, 2024 •
edited by pr-preview bot
Loading

  • add challenge creation endpoint \challenges
  • return ChallengeVerificationMetadata when options.challenge passed so client can track number of times challenge used
  • remove passing options.challenge and options.domain to incorrect endpoints

Preview | Diff

@wes-smith wes-smith linked an issue Feb 28, 2024 that may be closed by this pull request
Add challenge management endpoint to verifying APIs #310
Closed
dlongley
dlongley reviewed Mar 5, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
dlongley
dlongley reviewed Mar 5, 2024
View reviewed changes
holder.yml Outdated Show resolved Hide resolved
This was referenced Mar 5, 2024
Closed
Merged
@wes-smith
Copy link
Collaborator Author

#376 opened to address how verify endpoint responses should be restructured to contain challenge metadata.

dlongley
dlongley reviewed Mar 8, 2024
View reviewed changes
components/Challenge.yml Outdated Show resolved Hide resolved
TallTed
TallTed reviewed Mar 8, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
dlongley
dlongley approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/given suggestions.

holder.yml Outdated Show resolved Hide resolved
verifier.yml Outdated Show resolved Hide resolved
wes-smith and others added 4 commits March 19, 2024 14:34
@wes-smith
Add challenge endpoint.
3c194b5 
- add challenge creation endpoint
- remove passing `options.challenge` and `options.domain` to incorrect endpoints
@wes-smith @msporny @dlongley
Add firstVerified to challenge metadata, update wording, remove Chall…
1b61b18 
…engeVerificationMetadata from results.

Co-authored-by: Manu Sporny <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
@wes-smith
Remove ChallengeVerificationMetadata from responses..
f41990c
@wes-smith @dlongley @TallTed
Apply changes from code review to formatting, property naming, and en…
0f47ef8 
…dpoint description.

Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@wes-smith wes-smith force-pushed the 310-add-challenge-management-endpoint-to-verifying-apis branch from 3589fb3 to 0f47ef8 Compare March 19, 2024 18:40
@msporny msporny merged commit afcb511 into main Mar 26, 2024
1 check passed
@msporny msporny deleted the 310-add-challenge-management-endpoint-to-verifying-apis branch March 26, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@msporny msporny msporny approved these changes

@dlongley dlongley dlongley approved these changes

@mavarley mavarley Awaiting requested review from mavarley mavarley is a code owner

@mkhraisha mkhraisha Awaiting requested review from mkhraisha mkhraisha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add challenge management endpoint to verifying APIs
4 participants
@wes-smith @msporny @dlongley @TallTed