Allow initiation of exchange to contain a VPR. #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wes-smith
commented
Jul 16, 2024
wes-smith
commented
- allows a client to get information about what the server will need to complete an exchange before making calls that might result in issuance.
- allows a client to get information about what the server will need to complete an exchange before making calls that might result in issuance.
msporny
reviewed
Jul 16, 2024
exchanges.yml
Outdated
Comment on lines
137
to
138
| response from the server, if the server will need a Verifiable Presentation from the client during the exchange, or a | ||
| 400 error if the server will issue in response to an empty body. |
There was a problem hiding this comment.
a 400 error if the server will issue in response to an empty body
This last bit is not quite clear, probably just needs more words and a grammar fix.
msporny
reviewed
Jul 16, 2024
exchanges.yml
Outdated
Comment on lines
136
to
138
| to start the exchange will result in either a Verifiable Presentation Request response from the server, | ||
| if the server will need a Verifiable Presentation from the client during the exchange, or a | ||
| 4XX error if the server will issue in response to an empty body. |
There was a problem hiding this comment.
Suggested change
| to start the exchange will result in either a Verifiable Presentation Request response from the server, | |
| if the server will need a Verifiable Presentation from the client during the exchange, or a | |
| 4XX error if the server will issue in response to an empty body. | |
| to start the exchange will result in either a Verifiable Presentation or a Verifiable | |
| Presentation Request that conforms to the client's request, or a 4xx error. |
TallTed
reviewed
Jul 16, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
msporny
approved these changes
Jul 16, 2024
msporny
deleted the
387-consider-allowing-a-client-to-request-information-about-an-exchange-via-non-empty-post-body
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.