Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Scrolling Feed Example: Add fallback foreground color #3150

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

giacomo-petri
Copy link
Contributor

@giacomo-petri giacomo-petri commented Oct 22, 2024

Closes: #3149

Description: Added a fallback foreground color of #000 to the body element in the Infinite Scrolling Feed Example iframe to address the 1.4.3 contrast failure.


WAI Preview Link (Last built on Tue, 22 Oct 2024 13:55:25 GMT).

Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mcking65 mcking65 requested review from adampage and shirsha October 22, 2024 18:53
@mcking65 mcking65 changed the title Added a fallback foreground color to the Infinite Scrolling Feed Example iframe to resolve the 1.4.3 contrast failure [closes #3149] Infinite Scrolling Feed Example: Add fallback foreground color Nov 3, 2024
@mcking65 mcking65 merged commit ebb4476 into main Nov 3, 2024
21 checks passed
@mcking65 mcking65 deleted the giacomo-petri-feed-foreground-143-issue branch November 3, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Scrolling Feed Example Iframe - Background color is specified but foreground color is not
3 participants