Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise role=presentation example #1699

Merged
merged 1 commit into from
Apr 15, 2022
Merged

revise role=presentation example #1699

merged 1 commit into from
Apr 15, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 5, 2022 •
edited by pr-preview bot
Loading

closes #1647

  • removes examples which are unclear without including notes about some current AT behaviors.
  • updates reference to the fact that a span is a type of generic.
  • some minor editorial updates to surrounding content

Preview | Diff

@scottaohara
Update index.html
7225167 
closes #1647

- removes examples which are unclear without including notes about some current AT behaviors.
- updates reference to the fact that a `span` is a type of `generic`.
- some minor editorial updates to surrounding content
@scottaohara scottaohara mentioned this pull request Mar 5, 2022
Closed
@pkra pkra added this to the ARIA 1.3 milestone Mar 7, 2022
chlane
chlane approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@chlane chlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will help authors better understand the behavior of role=presentation

Jaunita-George
Jaunita-George approved these changes Mar 11, 2022
View reviewed changes
Copy link

@Jaunita-George Jaunita-George left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!

MelSumner
MelSumner approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Improves it! :shipit:

@pkra pkra merged commit 87d775b into main Apr 15, 2022
@pkra pkra deleted the scottaohara-issue-1647 branch April 15, 2022 16:31
github-actions bot added a commit that referenced this pull request Apr 15, 2022
@scottaohara @github-actions
Update index.html (#1699)
d758226 
SHA: 87d775b
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Jaunita-George
Jaunita-George reviewed Apr 15, 2022
View reviewed changes
Copy link

@Jaunita-George Jaunita-George left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

pkra pushed a commit that referenced this pull request Jul 14, 2022
@scottaohara @pkra
Update index.html (#1699)
46ba876 
closes #1647

- removes examples which are unclear without including notes about some current AT behaviors.
- updates reference to the fact that a `span` is a type of `generic`.
- some minor editorial updates to surrounding content
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@scottaohara @jnurthen
Update index.html (#1699)
3b1ee54 
closes #1647

- removes examples which are unclear without including notes about some current AT behaviors.
- updates reference to the fact that a `span` is a type of `generic`.
- some minor editorial updates to surrounding content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaunita-George Jaunita-George Jaunita-George approved these changes

@MelSumner MelSumner MelSumner approved these changes

@chlane chlane chlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

Question: role presentation on non-semantic elements - why?
5 participants
@scottaohara @MelSumner @chlane @Jaunita-George @pkra