Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes images and adds samples #56

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

mkhraisha
Copy link
Contributor

Adds images to the samples file.

Unsure if mermaid files will work like this or not, would love if anyone has insights on this.

specifically subsections under section 2.5 don't seem to work on my machine

@dontcallmedom
Copy link
Member

dontcallmedom commented Dec 11, 2024

I don't think the images are working as you expect: the fact that they use blob:http://localhost:3000/ urls make me imagine because they're generated via JS before being exported via respec. Fixing this I'm afraid is more involved than what I can help with in the context of publishing final specifications - assuming this is done via https://github.com/w3c/respec-mermaid, maybe ask for support there?

@mkhraisha
Copy link
Contributor Author

Thank you.
Ill go through fixing the mermaid files soon, but for now I have removed the .js files that were referencing mermaid.

This PR fixes a significant number of missing images though, can it still be merged in?

@dontcallmedom dontcallmedom merged commit 754e2fa into w3c:main Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants