Repository navigation
Expand shortname RegExp and avoid OS-specific path separators - #26
Merged
Merged
Conversation
deniak
reviewed
Sep 29, 2026
deniak
approved these changes
Sep 29, 2026
deniak
left a comment
deniak
left a comment
Member
There was a problem hiding this comment.
Except for the comment I made on the last-modified collector, the PR looks good! Thanks
kfranqueiro
force-pushed
the
kgf-regexp-and-path-separator
branch
from
September 29, 2026 14:42
ded5ed5 to
baf9fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the RegExp used to validate shortnames, to allow hyphen and period after the first character, and allow uppercase letters.
It also removes unnecessary instances of hard-coded path separators, and replaces any necessary instances with
joinorsepfrom the path module.I also reordered some imports to group all
./imports together, and replaced'with"in any places inindex.jswhere I was making changes anyway to match default prettier rules (there are still some remaining outliers). I later realized while editingutils.jsthat that file consistently used'everywhere, whereas those cases seemed outnumbered inindex.js; either way, settling on one or the other is a matter for a separate PR.