Skip to content

Get the URL and the repository from browser-specs - #35

Open
deniak wants to merge 7 commits into
mainfrom
browser-specs-url-repo
Open

deniak wants to merge 7 commits into
mainfrom
browser-specs-url-repo

Conversation

@deniak

@deniak deniak commented Oct 6, 2026

Copy link
Copy Markdown
Member

That PR leverages browser-specs to get the URL and the repo for each spec.

If a spec is unknown, an error is returned and if the shortname used is an old one, a warning is issued. The idea is to deal with this manually.

@tidoust mentioned that the tests property in browser-specs should also give us the right WPT path but in some cases, e.g. speculation-rules, I'm not sure how they are dealing with the different features. In any case, it's good to have a fallback mechanism until WPT has the data we need.

Fix #33

@deniak
deniak requested a review from kfranqueiro October 6, 2026 16:12
@tidoust

tidoust commented Oct 6, 2026

Copy link
Copy Markdown
Member

@tidoust mentioned that the tests property in browser-specs should also give us the right WPT path but in some cases, e.g. speculation-rules, I'm not sure how they are dealing with the different features.

In theory, there should be a META.yml file in appropriate subfolders. The tests property in browser-specs both has a testPaths key that lists WPT folders to include and an excludePaths key that lists subfolders within these folders that should not be taken into account.

The information in WPT does not seem up-to-date for the speculation-rules folder. At a minimum, a META.yml file is missing from speculation-rules/prefetch. There are likely other updates needed there in theory because the initial speculation-rules spec got partially merged into HTML.

@tidoust

tidoust commented Oct 6, 2026

Copy link
Copy Markdown
Member

The information in WPT does not seem up-to-date for the speculation-rules folder. At a minimum, a META.yml file is missing from speculation-rules/prefetch. There are likely other updates needed there in theory because the initial speculation-rules spec got partially merged into HTML.

I created web-platform-tests/wpt#63327 to update the information in WPT.

Comment thread test/specs.test.js
Comment thread specs.js Outdated
Comment thread test/specs.test.js Outdated
Comment thread index.js
dataMap.set(result.shortname, result);
});

const merged = specs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to filter this way, vs. referencing resolvedSpecs?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolvedSpecs is a subset of specs (with additional properties). So if for some reasons, a spec listed in specs.json is dropped out from browser-specs, it will no longer be in resolvedSpecs and hence, will not be processed.
Filtering specs will ensure we keep the existing data available until specs.json is cleaned up. index.js will report an error (l.130) in such case and a manual cleanup is expected.

Co-authored-by: Kenneth G. Franqueiro <kfranqueiro@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leverage browser-specs to get spec URL and repo

3 participants