Skip to content

Conversation

@andruud
Copy link
Member

@andruud andruud commented Oct 21, 2025

For example:
LINE 330:39: Character reference '&Bar' didn't end in ;.

Replaced various instances of & with &.

For example:
LINE 330:39: Character reference '&Bar' didn't end in ;.

Replaced various instances of '&' with '&'.
@andruud andruud requested a review from tabatkins October 21, 2025 07:48
@SebastianZ SebastianZ self-requested a review October 22, 2025 06:40
Copy link
Contributor

@SebastianZ SebastianZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an obvious bugfix. So fine for me.

I'd argue that the enclosing in '' seems also wrong to me, because Bikeshed then tries to link those terms, but that can be done in a follow up.

Sebastian

@SebastianZ SebastianZ merged commit d0bbc17 into w3c:main Oct 22, 2025
1 check passed
@andruud andruud deleted the nesting_ampersands2 branch October 22, 2025 06:43
@tabatkins
Copy link
Member

I'd argue that the enclosing in '' seems also wrong to me, because Bikeshed then tries to link those terms, but that can be done in a follow up.

Note that the ''foo'' syntax has traditionally been used both for linking CSS values and for just marking stuff up in a particular style as CSS content. Bikeshed's cool with that. When it's occasionally problematic, the <css>...</css> fake element can be used for styling.

So continuing to use it for selectors as it is here is fine.

(This mixing is problematic in Bikeshed's parser impl - it needs to simultaneously parse as HTML and parse as raw text, and decide which is correct only after resolving links - but oh well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants