-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shacl12-node-expr, shacl12-inf-rules #237
base: gh-pages
Are you sure you want to change the base?
Conversation
Shouldn't this include 12, e.g. shacl12-node-expr? |
There is the short name for the series and the short name for each version. "Short names" are keys in various W3C systems so they get copied around. Changing them later is disruptive. I think it might need a WG resolution to point to so the W3C system team can action things. I'm not sure which one is is most important, or maybe both. (This isn't something I have done very often.) Changed to And about the names themselves? Longer or shorter? |
The names look good to me, as they are supposed to be "short". |
And if we do the 12 in the name, shouldn't then the folder also be like shacl12-inf-rules? |
Yes, we have both in some cases: when the new version does not supersede the previous one.
True
The decision is to be made formally by the WG when we publish the first public Working Draft. We can have different naming in GH (e.g. shacl-node-expr in GH but /TR/shacl-node-expressions when finally published) |
…re12 spec structure; add prettier config
…node-expr; add prettier config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed respec errors and aligned the section structure with the one of shacl12-core
shacl-node-expr/.prettierrc
Outdated
@@ -0,0 +1,14 @@ | |||
{ | |||
"useTabs": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use tabs. They come out differently for different people/IDEs.
If they get mixed, then indentation can look quite irregular.
Does prettier work with reSpec?
The usual problem I encounter is the breaking lines inside links - legal but then the link e.g. a data-cite
is unclear.
This PR adds two documents, one for node expressions and one for inference rules. (The document are empty in this PR. The CSS is lifted from an existing SHACl document.)
See #234 (comment) for the initial discussion.
The important point of this PR is the short names.
The short names in the initial PR are "shacl-node-expr" and "shacl-inf-rules".
Short names are the path component after
/TR/
so they show up,We could use longer "short names"
"shacl-node-expressions", "shacl-inference-rules"