Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest CLI test is failing -- possibly resolver test code issue #111

Closed
shigeya opened this issue May 18, 2021 · 4 comments
Closed

Jest CLI test is failing -- possibly resolver test code issue #111

shigeya opened this issue May 18, 2021 · 4 comments

Comments

@shigeya
Copy link
Contributor

shigeya commented May 18, 2021

Running jest (npm run test) on the current head of the main branch produces a lot of errors.

While there is at least a minor issue in PR #96 (one file is missing), currently,

  • all of the implementation JSON files are from the PR#96
  • all of the resolving tests are failing

There might be some issue with the resolver testing code.
@peacekeeper Since you're the implementer of the test code, would you please kindly check the reason why they're failing?
since universal-resolver-did-factom.json is missing, you need to remove the following line in did-resolution/default.js.

// require('../implementations/universal-resolver-did-factom.json'), -- MISSING

I created PR #110 for a temporary workaround.

@shigeya shigeya changed the title Jest CLI test is failing -- possibly resolver test issue Jest CLI test is failing -- possibly resolver test code issue May 18, 2021
@BernhardFuchs
Copy link
Contributor

Sorry for breaking the imports by referencing a not existing file. Actually the did:factom method is not working atm and should not be included in the default.js file. So the quick fix for everybody is to remove this line.
We did some changes the process of creating the files/imports for the testsuite which should fix and avoid those kind of issues.

There are also some changes to the Universal Resolver which will fix test failures but we won't be able to have a 100% green testsuite atm.

By the end of the week, I will create a PR will all the changes.

@BernhardFuchs
Copy link
Contributor

I've opened #114 which should fix most issues.
There are still ~15 tests failing with 4 of them related to the Universal Resolver and one of its drivers decentralized-identity/uni-resolver-driver-did-ccp#5

@BernhardFuchs
Copy link
Contributor

BernhardFuchs commented May 20, 2021

After disabling resolver-ethr-consensys-mesh.json (which is also the case on main), the failing tests are down to 7 across the whole test-suite with #114

@msporny
Copy link
Member

msporny commented Jun 6, 2021

This has now been fixed, we put broken implementations in their own grouping (but do run these when generating the final report).

@msporny msporny closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants