Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Universal Resolver implementations #96

Merged
merged 5 commits into from
May 16, 2021

Conversation

BernhardFuchs
Copy link
Contributor

  • All drivers which return a 200 Status code
  • did+ld+json representation
  • only defaultOutcomes

@BernhardFuchs BernhardFuchs marked this pull request as draft May 10, 2021 16:14
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big one :)

I recommend we give it right of way for merging, when its ready.

@BernhardFuchs
Copy link
Contributor Author

@OR13 @msporny This is done from our side.
It includes good cases for all Universal Resolver drivers which return a 200.

The files are generated in a semi-automatic process with these scripts in the ci. The idea here is to have a ci-step to run the results of the Universal Resolver against a hosted version of the did-test-suite (probably a cron job). I'm struggling a bit with the input parameters to the /generate-report endpoint. See #104

@OR13
Copy link
Contributor

OR13 commented May 13, 2021

@BernhardFuchs what is remaining to move this from draft to mergable?

@BernhardFuchs BernhardFuchs marked this pull request as ready for review May 14, 2021 09:20
@BernhardFuchs
Copy link
Contributor Author

We have just added two more (ebsi and sol) examples.
Otherwise this is ready to merge.

@msporny
Copy link
Member

msporny commented May 14, 2021

@BernhardFuchs Please fix merge conflicts...

@BernhardFuchs
Copy link
Contributor Author

@msporny Conflicts are resolved

@shigeya
Copy link
Contributor

shigeya commented May 18, 2021

@BernhardFuchs Hi, the current test run is failing after the merge of this commit. I raised issue #111. please kindly check the issue.

Note that I found this file is missing: implementations/universal-resolver-did-factom.json
Please kindly provide the file. Maybe, as a PR?

@picardcapt1212
Copy link
Contributor

picardcapt1212 commented May 20, 2021

Hello, i have a question.
We created "did:lit" method and registered our resolver in universal resolver.
While processing the did test suite we realized our did method should be changed,
which means universal resolver example did document should also change.

But i checked our "did:lit" resolver is already merged as "implementations/universal-resolver-did-lit.json".
I think if we update "did:lit" method, "didDocumentStream" field in "implementations/universal-resolver-did-lit.json" will slightly change.

How should i update this? Should i just change it manually and request pr?
Looking forward to your reply. Thank you.

@BernhardFuchs
Copy link
Contributor Author

@picardcapt1212 We are currently creating implementations-files for all working drivers on the Universal Resolver but that doesn't mean we are the authorithy over them. So feel free to create a PR with the updated implementations/universal-resolver-did-lit.json or create your own file in the implementations folder.

The only issue I see here, is that we have a semi-automated process to create those files. In case you have updated the implementations/universal-resolver-did-lit.json file but the driver for the Universal Resolver still produces the outdated result, we can't guarantee that the universal-resolver-did-lit.json doesn't get overwritten with deprecated data. That's why we prefixed all the Universal Resolver related files with universal-resolver-did-.

@picardcapt1212
Copy link
Contributor

@picardcapt1212 We are currently creating implementations-files for all working drivers on the Universal Resolver but that doesn't mean we are the authorithy over them. So feel free to create a PR with the updated implementations/universal-resolver-did-lit.json or create your own file in the implementations folder.

The only issue I see here, is that we have a semi-automated process to create those files. In case you have updated the implementations/universal-resolver-did-lit.json file but the driver for the Universal Resolver still produces the outdated result, we can't guarantee that the universal-resolver-did-lit.json doesn't get overwritten with deprecated data. That's why we prefixed all the Universal Resolver related files with universal-resolver-did-.

Okay, then i guess if we update lit-resolver we have and also update implementations/universal-resolver-did-lit.json there will be no problem..

Thank you for reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants