-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #117 #118
Fixes #117 #118
Conversation
Is this stale @stevefaulkner? If still good, @carmacleod, could you fix the merge conflict? |
thanks for PR @carmacleod "This branch has conflicts that must be resolved" |
@marcoscaceres Branch is refreshed; conflicts resolved. @stevefaulkner Just so you know, I made 2 additional (but tiny) changes:
|
Marked as non substantive for IPR from ash-nazg. |
Thanks @carmacleod for the update 🧁. Over to @stevefaulkner for final review and to answer your questions. |
Looking over this, it is an improvement to clarify the information and I'm going to merge it in, but noting there's additional work to do / consider in #63. |
minor source cleanup but also fix complimentary to complementary as noted in comments in the merged PR #118
Fixes #117
Preview | Diff