Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #117 #118

Merged
merged 3 commits into from
Sep 29, 2019
Merged

Fixes #117 #118

merged 3 commits into from
Sep 29, 2019

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Oct 24, 2018

Fixes #117


Preview | Diff

@marcoscaceres
Copy link
Member

Is this stale @stevefaulkner? If still good, @carmacleod, could you fix the merge conflict?

@stevefaulkner
Copy link
Collaborator

stevefaulkner commented Jun 28, 2019

thanks for PR @carmacleod "This branch has conflicts that must be resolved"

@carmacleod
Copy link
Contributor Author

@marcoscaceres Branch is refreshed; conflicts resolved.

@stevefaulkner Just so you know, I made 2 additional (but tiny) changes:

  1. Since nav had the (changed) keyword, I figure role=navigation needed it too - correct?
  2. I added the word "then" because with all those words crammed into a table cell, it was confusing to read, and "then" adds clarity.

@marcoscaceres
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

@marcoscaceres
Copy link
Member

Thanks @carmacleod for the update 🧁. Over to @stevefaulkner for final review and to answer your questions.

@scottaohara
Copy link
Member

scottaohara commented Sep 29, 2019

@stevefaulkner, @carmacleod

Looking over this, it is an improvement to clarify the information and I'm going to merge it in, but noting there's additional work to do / consider in #63.

@scottaohara scottaohara merged commit 6624325 into w3c:gh-pages Sep 29, 2019
scottaohara added a commit that referenced this pull request Sep 29, 2019
minor source cleanup but also fix complimentary to complementary as noted in comments in the merged PR  #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

header/footer implicit role needs to include ancestor element's implied role (not just element type)
4 participants