Add Declarative Web Push #385
Conversation
There was a problem hiding this comment.
I'd like to see more explanatory text attached to this sort of change. (In the spec, not the PR, for avoidance of doubt.)
From what I can see, a message is opportunistically parsed as JSON. If it parses and there is a "web_push": 9001 (?!) attribute, the browser attempts to make a notification. If that works, the notification is shown.
There is also a mutable attribute attached, which would allow the SW the option of intercepting the notification and tweaking it before it is shown. That would somewhat negate the benefits from a purely declarative notification, so it seems an unnecessary feature (the app could save the "web_push": 9001 bytes and just make a notification for itself).
index.html
Outdated
| If a notification has been shown through {{showNotification()}} at this | ||
| point, then abort these steps. |
There was a problem hiding this comment.
This seems non-ideal. I don't know how this is supposed to work, but this requires a trap in showNotification to track, but you aren't monkey-patching that. Does preventDefault not work?
There was a problem hiding this comment.
I mean, this statement is monkey patching that. Certainly seems reasonable to tidy it up though. (preventDefault() wouldn't guarantee that a notification is shown.)
This introduces a new feature whereby push messages conforming to a certain JSON format directly create an end user notification and show it (possibly preceded by a new pushnotification event). In addition to showing a notification, the app badge can be updated as well. This builds on whatwg/notifications#213 which adds URL members to notifications. Exposing PushManager outside of service workers will be done in a separate change.
annevk
force-pushed
the
declarative-push
branch
from
7b3b218
to
4f6bd92
Compare
This introduces a new feature whereby push messages conforming to a certain JSON format directly create an end user notification and show it (possibly preceded by a new pushnotification event).
In addition to showing a notification, the app badge can be updated as well.
This builds on whatwg/notifications#213 which adds URL members to notifications.
Exposing PushManager outside of service workers will be done in a separate change.
The following tasks have been completed:
Implementer support:
Preview | Diff