Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "size" to "statusSize" #113

Closed
dlongley opened this issue Dec 29, 2023 · 5 comments
Closed

Rename "size" to "statusSize" #113

dlongley opened this issue Dec 29, 2023 · 5 comments
Assignees
@msporny
Labels
before-CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists

Comments

@dlongley
Copy link
Contributor

size is actually the size of the status, not the size of the list, as it is presently modeled. This is misnamed/mismodeled and should probably become statusSize.
@msporny msporny added the before-CR This issue needs to be resolved before the Candidate Recommendation phase. label Dec 29, 2023
@msporny msporny self-assigned this Dec 29, 2023
@msporny
Copy link
Member

msporny commented Dec 29, 2023

Should it be statusEntrySize instead? Given that we have multibit entries now, I've been trying to figure out how to reformulate the specification to convey that concept. Other words include "item" and "element".

@msporny msporny mentioned this issue Dec 30, 2023
Merged
@dlongley
Copy link
Contributor Author

Well, to me, "status entry" makes me think of a BitstringStatusEntry which is something else from the status value itself. If statusSize doesn't work, perhaps statusValueSize ... but I don't know that we need the extra word.

@dlongley
Copy link
Contributor Author

I'll note that we currently use status to express (in hex) status values in statusMessage, which, I believe, means statusSize (or statusValueSize if we want the longer name) makes sense.

@msporny
Copy link
Member

msporny commented Jan 2, 2024

The fix has been applied in PR #109. This issue will be closed once PR #109 has been merged.

@msporny
Copy link
Member

msporny commented Jan 13, 2024

PR #109 has been merged, closing.

@msporny msporny closed this as completed Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
before-CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @dlongley