Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BitstringStatusList context to align with latest spec. #109

Merged
merged 6 commits into from
Jan 13, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Dec 29, 2023

This PR is an attempt at addressing issue #70, which updates the context to align with the latest specification.

It preserves the old 2021 status list since that's where the w3id.org redirect goes currently, and we believe some organizations have deployed 2021 status list into potentially production environments. We need to preserve that file for now in order to not break implementations that aren't (mistakenly) caching their JSON-LD Contexts until we can move it back to the CCG or host it elsewhere (or decide to continue hosting it here).


Preview | Diff

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this is an improvement -- we'll probably need additional tweaking after more discussion around things like ttl, etc.

"https://www.w3.org/ns/credentials/status-list#encodedList",
"ttl": "https://www.w3.org/ns/credentials/status-list#ttl",
"reference": "https://www.w3.org/ns/credentials/status-list#reference",
"size": "https://www.w3.org/ns/credentials/status-list#size",
Copy link
Contributor

@dlongley dlongley Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the size of the status (not the size of the list). This is misnamed/mismodeled and should probably be statusSize.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being tracked in issue #113 (but we might as well make the change here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 35860ac.

"encodedList":
"https://www.w3.org/ns/credentials/status-list#encodedList",
"ttl": "https://www.w3.org/ns/credentials/status-list#ttl",
"reference": "https://www.w3.org/ns/credentials/status-list#reference",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a reference for the list, but for the status (or statuses). The main use case envisaged at the moment is for a dictionary of statuses / status messages. This should be renamed to statusReference on that basis.

Copy link
Member Author

@msporny msporny Dec 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being tracked in issue #114 (but we might as well make the change here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 35860ac.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msporny
Copy link
Member Author

msporny commented Jan 13, 2024

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 7b460ab into main Jan 13, 2024
1 of 2 checks passed
@msporny msporny deleted the msporny-update-context branch January 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants